Skip to content

[ConsumeAddrChecker] Diagnose consumes of borrows. #74360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

nate-chandler
Copy link
Contributor

When checking a mark_unresolved_move_addr instruction, first check whether it is legal to consume the source.

rdar://127518559&125817827

When checking a `mark_unresolved_move_addr` instruction, first check
whether it is legal to consume the source.

rdar://127518559&125817827
@nate-chandler nate-chandler requested a review from kavon as a code owner June 12, 2024 20:19
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

@nate-chandler nate-chandler requested a review from atrick June 12, 2024 20:20
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-chandler
Copy link
Contributor Author

UPasses:
  UPASS: rdar://128175704, penny-bot, 5.10, b30d76, Swift Package

@nate-chandler nate-chandler merged commit 6694bba into swiftlang:main Jun 13, 2024
6 of 8 checks passed
@nate-chandler nate-chandler deleted the rdar127518559 branch June 13, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants