6.0: [ConsumeAddrChecker] Diagnose consumes of borrows. #74373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking a `mark_unresolved_move_addr` instruction, first check whether it is legal to consume the source. rdar://127518559&125817827
|
@swift-ci please test |
tbkka
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a class of overconsumes caused by compiling invalid code.
The
ConsumeOperatorCopyableAddressesCheckeris responsible for checking the validity of uses of theconsumeoperator applied to copyable values in addresses (such as vars, inout parameters, and address-only values).Previously, it did not check whether the address being consumed could be consumed in the first place. For example, guaranteed address-only parameters may not be consumed. These consumes should have been diagnosed but were not. The result was compiling invalid code that resulted in overconsumes.
Here, this is fixed by first checking whether the base from which the address being consumed is derived can be destroyed.
Scope: Affects ownership annotated code.
Issue: rdar://127518559&125817827
Original PR: #74360
Risk: Low.
Testing: Added and updated tests.
Reviewer: Andrew Trick ( @atrick )