[Windows] Update the Swift compiler to 5.10.1 #74512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test Windows |
|
@swift-ci smoke test macOS |
|
@swift-ci smoke test Linux |
etcwilde
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Hope this fixes the arm64 6.0 build issue since 5.10.1 pulls in a fix to IRGen to handle an instruction that wasn't completely implemented in the 5.10 compiler: #73354
Even if it doesn't, it seems reasonable to use a release compiler for building things over the development snapshot.
|
@swift-ci test Windows |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS |
hjyamauchi
reviewed
Jun 18, 2024
| @@ -719,22 +719,22 @@ function Fetch-Dependencies { | |||
| } | |||
|
|
|||
| function Get-PinnedToolchainTool() { | |||
| if (Test-Path "$BinaryCache\toolchains\${PinnedToolchain}\LocalApp\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin") { | |||
| return "$BinaryCache\toolchains\${PinnedToolchain}\LocalApp\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin" | |||
| if (Test-Path "$BinaryCache\toolchains\${PinnedToolchain}\LocalApp\Programs\Swift\Toolchains\5.10.1+Asserts\usr\bin") { | |||
There was a problem hiding this comment.
It may be good to factor out this version number to a variable and set it along with the URL/SHA256 above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.