[SILOptimizer] Handle the mark_dependence chain when eliminating copies in ClosureLifetimeFixup #74593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Azoy
pushed a commit
to Azoy/swift
that referenced
this pull request
Jun 25, 2024
[SILOptimizer] Handle the mark_dependence chain when eliminating copies in ClosureLifetimeFixup
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are in ClosureLifetimeFixup, we emit
mark_dependencefor non-trivial address operands, but we do so in a chaining fashion like:and the move only copy eliminator here wasn't handling this case. Let's handle it!
Resolves: rdar://130205636