Fixes to ClosureLifetimeFixup's copy elimination for noncopyable values #74768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On finding unrecognized user, reset `initialization` of the stack so that we don't inadvertently eliminate copy
|
@swift-ci smoke test |
|
Isn’t the latter resolved by: #74593? |
For a mark_dependence user of the stack, look through the mark_dependence chain to match the partial_apply. Since this is a superset of the `markDepChain` logic, remove that. So that we don't have 2 ways to check for the same.
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializationof the stack so that wedon't inadvertently eliminate copy
to match the partial_apply