[Macros] Ensure plugin process is alive before sending a message #74639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
macros-respawn-before-loadlibrary
branch
from
0115426 to
b383905
Compare
|
@swift-ci Please smoke test |
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
hamishknight
as code owners
hamishknight
approved these changes
Jun 24, 2024
bnbarham
approved these changes
Jun 24, 2024
rintaro
force-pushed
the
macros-respawn-before-loadlibrary
branch
from
b383905 to
ebc2e87
Compare
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadPluginLibraryplugin message is sent viasendMessageAndWaitWithoutLock()because it's already locked in outer context. When the plugin was crashed right beforeloadPluginLibrarycall,Plugin_spawnIfNeededwas not called and the message just failed to send. This caused confusing error.Make sure to call
Plugin_spawnIfNeeded()before sending a message insendMessageAndWaitWithoutLock()so the plugin is available for the message.