Skip to content

[6.0][Macros] Ensure plugin process is alive before sending a message #74671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 25, 2024

Cherry-pick #74639 into release/6.0

  • Explanation: When a plugin was crashed right before loadPluginLibrary call, the compiler didn't attempt to respawn the plugin, and the message was just failed to send. Which caused confusing error. Make sure to respawn the plugin if it's down, before sending a message.
  • Scope: Macro plugins
  • Risk: Low. Add more opportunity to respawning the process, the possible risk is a crash loop, but the newly added test case should be enough for verifying it won't happen
  • Testing: Added new test cases for crash recovery
  • Issues: rdar://130456715
  • Reviewer: Hamish Knight (@hamishknight) Ben Barham (@bnbarham) Alex Hoppen (@ahoppen)

@rintaro rintaro requested a review from a team as a code owner June 25, 2024 00:02
@rintaro
Copy link
Member Author

rintaro commented Jun 25, 2024

@swift-ci Please test

@rintaro rintaro changed the title [Macros] Ensure plugin process is alive before sending a message [6.0][Macros] Ensure plugin process is alive before sending a message Jun 25, 2024
@rintaro rintaro merged commit b4a169e into swiftlang:release/6.0 Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants