Concurrency: Fix multiple condfails #74943
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the new parameter is added in a compatible way where code which does not refer to it will get a defaulted nil value; since we refer to a new parameter name in source, we need to guard it with a language feature -- as old compilers will not have this new name available. This should prevent a potential condfail issue.
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
|
@swift-ci please smoke test |
|
It turns out I can modify Konrad's original PR, so using that: #74929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves multiple issues with the textual interface of the _Concurrency module for supported older compilers:
#if $BuiltinCreateAsyncTaskOwnedTaskExecutor.-enable-experimental-feature IsolatedAny(older compilers don't enable it by default).@_allowFeatureSuppression(IsolatedAny)attributes. The suppressed alternatives for these methods did not build and additionally they were leaking thesendingkeyword into scopes that were not protected by$SendingArgsAndResults.