[cxx-interop] Do not expose enums with optional generic cases #74966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
reviewed
Jul 4, 2024
Yeah, currently the code path would try to dereference a null pointer for code like that. I tried to make a fix but it was more involved than I anticipated, so I decided to make a quick fix for now and will add support for this case in a follow-up PR. |
Unfortunately, we cannot generate the C++ code for them just yet. There will be a follow-up PR to actually fix the underlying issue and expose such enums correctly. rdar://129250756
Xazax-hun
force-pushed
the
gaborh/stop-exporting-optional-generics
branch
from
d7c6a40 to
c56cca1
Compare
|
Rebased to resolve conflict. @swift-ci please smoke test |
Xazax-hun
added a commit
that referenced
this pull request
Jul 5, 2024
Explanation: The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++. Scope: C++ Reverse Interop Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test. Issue: rdar://129250756 Reviewer: @egorzhdan Original PR: #74966
Xazax-hun
added a commit
that referenced
this pull request
Jul 5, 2024
Explanation: The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++. Scope: C++ Reverse Interop Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test. Issue: rdar://129250756 Reviewer: @egorzhdan Original PR: #74966
Xazax-hun
added a commit
that referenced
this pull request
Jul 8, 2024
Explanation: The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++. Scope: C++ Reverse Interop Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test. Issue: rdar://129250756 Reviewer: @egorzhdan Original PR: #74966
Xazax-hun
added a commit
that referenced
this pull request
Jul 8, 2024
Explanation: The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++. Scope: C++ Reverse Interop Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test. Issue: rdar://129250756 Reviewer: @egorzhdan Original PR: #74966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we cannot generate the C++ code for them just yet. There will be a follow-up PR to actually fix the underlying issue and expose such enums correctly.
rdar://129250756