🍒[cxx-interop] Do not expose enums with optional generic cases #74987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
egorzhdan
approved these changes
Jul 5, 2024
DougGregor
reviewed
Jul 5, 2024
Xazax-hun
force-pushed
the
gaborh/stop-exporting-optional-generics-cherry-pick
branch
from
2b60276 to
474b6fa
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Jul 5, 2024
Xazax-hun
force-pushed
the
gaborh/stop-exporting-optional-generics-cherry-pick
branch
from
474b6fa to
f6b8524
Compare
|
@swift-ci please test There was a failure due to differences in this test file between main and release/6.0. Attempting to fix. |
|
@swift-ci please test |
Explanation: The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++. Scope: C++ Reverse Interop Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test. Issue: rdar://129250756 Reviewer: @egorzhdan Original PR: #74966
Xazax-hun
force-pushed
the
gaborh/stop-exporting-optional-generics-cherry-pick
branch
from
f6b8524 to
56b82bd
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
The code path trying to generate the C++ header for enums that have cases with associated values of a generic optional type resulted in null pointer dereference. The proper fix is a bit more involved so this PR just temporarily avoids exposing the problematic enums to C++.
Scope: C++ Reverse Interop
Risk: Low, we stop exposing enums that were crashing the compiler before. Testing: Added a regression test.
Issue: rdar://129250756
Reviewer: @egorzhdan
Original PR: #74966