[ClangImporter] Adjust tests after Clang changes for __attribute__((pure))
#75055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pure))` There was a recent change in Clang's handling of `__attribute__((pure))`: llvm/llvm-project#78200 `__attribute__((pure))` is now dropped for const functions, and for functions that return `void`. This adjusts the test for the new behavior. There might be future changes required in the Swift's handling of `__attribute__((pure))`. rdar://131300381
|
@swift-ci please test |
Xazax-hun
reviewed
Jul 8, 2024
| @@ -54,7 +54,7 @@ struct Base { | |||
| return i * 2; | |||
| } | |||
|
|
|||
| void pure() const __attribute__((pure)) {} | |||
There was a problem hiding this comment.
I think the const might not be a problem here. I think the const in the clang change might refer to the attribute: https://clang.llvm.org/docs/AttributeReference.html#const
That being said, I am also OK leaving the PR as is.
There was a problem hiding this comment.
Oh, you're right! Let me bring back const.
|
Closing this in favor of #75058. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a recent change in Clang's handling of
__attribute__((pure)): llvm/llvm-project#78200__attribute__((pure))is now dropped for const functions, and for functions that returnvoid.This adjusts the test for the new behavior. There might be future changes required in the Swift's handling of
__attribute__((pure)).rdar://131300381