[cxx-interop] Clone all of the attributes from base method correctly #75058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a C++ `struct Base` declares a method with a Clang attribute that Swift is able to import, and `struct Derived` inherits from `Base`, the method should get cloned from `Base` to `Derived` with its attributes. Previously we were only cloning one attribute at most due to a bug in `cloneImportedAttributes`. DeclAttributes is an intrusively linked list, and it was being made invalid while iterating over it: `otherDecl->getAttrs().add(attrs)` iterates over the list and calls `otherDecl->add(eachElement)`, which invalidates the iterator after the first iteration.
egorzhdan
requested review from
zoecarver,
hyp,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a C++
struct Basedeclares a method with a Clang attribute that Swift is able to import, andstruct Derivedinherits fromBase, the method should get cloned fromBasetoDerivedwith its attributes.Previously we were only cloning one attribute at most due to a bug in
cloneImportedAttributes. DeclAttributes is an intrusively linked list, and it was being made invalid while iterating over it:otherDecl->getAttrs().add(attrs)iterates over the list and callsotherDecl->add(eachElement), which invalidates the iterator after the first iteration.