[sending] Replace sending with consuming when suppressing sending from arguments in swiftinterface files. #75075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m arguments in swiftinterface files. Previously we would just not print sending. This causes problems since sending implies a +1 parameter and by removing it we convert the parameter to a +0 parameter, breaking ABI. In this commit, I make it so that when we suppress sending from argument parameters, we just replace it with consuming so that we preserve ABI even for callers who do not support sending. rdar://131066640
gottesmm
requested review from
ktoso,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci smoke test |
tshortli
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sending] Replace sending with consuming when suppressing sending from arguments in swiftinterface files.
Previously we would just not print sending. This causes problems since sending implies a +1 parameter and by removing it we convert the parameter to a +0 parameter, breaking ABI. In this commit, I make it so that when we suppress sending from argument parameters, we just replace it with consuming so that we preserve ABI even for callers who do not support sending.
rdar://131066640