[6.0][sending] Replace sending with __owned when suppressing sending from arguments in swiftinterface files. #75153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m arguments in swiftinterface files. Previously we would just not print sending. This causes problems since sending implies a +1 parameter and by removing it we convert the parameter to a +0 parameter, breaking ABI. In this commit, I make it so that when we suppress sending from argument parameters, we just replace it with consuming so that we preserve ABI even for callers who do not support sending. rdar://131066640 (cherry picked from commit fdd435a)
The reason why I am doing this is that consuming could cause no implicit copy errors. Instead __owned will just potentially cause an error if someone assigns into sending. rdar://131066640 (cherry picked from commit 63146bc)
|
@swift-ci test |
hborla
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Previously we would just not print sending. This causes problems since sending
implies a +1 parameter and by removing it we convert the parameter to a +0
parameter, breaking ABI. In this commit, I make it so that when we suppress
sending from argument parameters, we just replace it with __owned so that we
preserve ABI even for callers who do not support sending.
Radars:
Original PRs:
Risk: Low. This is a really simple change that just tweaks the code that stops printing sending to instead print __owned. On the face of it, it is a safe patch.
Testing: Updated exhaustive tests that show that we now produce __owned instead of nothing.
Reviewer: @tshortli