Skip to content

LifetimeDependenceDiagnostics support for inout reassignment. #75162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jul 11, 2024

This relies on parameter dependence targets.
i.e. dependsOn in parameter position instead of result position.

@atrick
Copy link
Contributor Author

atrick commented Jul 30, 2024

@swift-ci test

@atrick
Copy link
Contributor Author

atrick commented Jul 30, 2024

TestFoundation/TestURLSession.swift:637: error: TestURLSession.test_connectTimeout : XCTAssertEqual failed: ("nil") is not equal to ("Optional(Foundation.URLError.Code.timedOut)") - Task should fail with URLError.timedOut error

atrick added 6 commits July 30, 2024 15:57
Handle situations in which the uses of the new scope are inside a loop so the
new range has no end instructions.
This relies on parameter dependence targets.

i.e. dependsOn in parameter position instead of result position.
A nonescapable computed property should always depend on 'newValue'. We simply
infer that now. There's no way to explicitly spell the dependence.
We need this at least until we have 'dependsOn(self)' syntax.

When 'self' is nonescapable and the result is 'void', assume that 'self' depends
on a single nonescapable argument.
@atrick
Copy link
Contributor Author

atrick commented Jul 30, 2024

@swift-ci smoke test

@atrick atrick enabled auto-merge July 31, 2024 02:25
@atrick atrick merged commit fe238cf into swiftlang:main Jul 31, 2024
3 checks passed
@atrick atrick deleted the inout-dep branch July 31, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant