Skip to content

[nfc] LifetimeDiagnostics cleanup #75562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2024
Merged

[nfc] LifetimeDiagnostics cleanup #75562

merged 7 commits into from
Jul 30, 2024

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jul 30, 2024

NFC changes required for: LifetimeDependenceDiagnostics support for inout reassignment. #75162

Minor cleanup and infrastructure

  • a new assert in Builder.init(after:)
  • BridgedOStream and debugLog()

So we can trace optimizer passes using the same output stream as the
C++ passes and don't get garbled output.
@atrick
Copy link
Contributor Author

atrick commented Jul 30, 2024

@swift-ci test

atrick added 6 commits July 29, 2024 23:44
This API is incorrect for terminators. Assert that it isn't used
incorrectly. Later, we should rename it.
Add interfaces to FunctionConventions and ArgumentConventions for querying
lifetime dependencies where the target is another parameter.
@atrick
Copy link
Contributor Author

atrick commented Jul 30, 2024

@swift-ci smoke test

@atrick atrick merged commit d065a3e into swiftlang:main Jul 30, 2024
3 checks passed
@atrick atrick deleted the nfc-lifedep branch July 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant