Skip to content

[Debug] Rename DebugDescription fallback property to lldbDescription #75289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Jul 17, 2024

  • Explanation:
    From feedback, replace the name _debugDescription, which was confusing because of the underscore, with lldbDescription.
  • Scope:
    This will not break existing code. Any existing uses of _debugDescription would see that the debugger does not produce a summary string, but would still display all fields/children of a value.
  • Original PRs:
    [Debug] Rename DebugDescription fallback property to lldbDescription #75305
  • Risk:
    Early adopters of _debugDescription will not see their summary string shown.
  • Testing:
    Swift tests, CI.
  • Reviewers:
    @hborla, @stephentyrone, @DougGregor

@kastiglione kastiglione requested a review from a team as a code owner July 17, 2024 14:33
@kastiglione
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the release cherry pick template

@kastiglione kastiglione requested a review from hborla July 17, 2024 21:09
@kastiglione kastiglione merged commit cda4171 into release/6.0 Jul 25, 2024
5 checks passed
@kastiglione kastiglione deleted the dl/Debug-Rename-DebugDescription-fallback-property-to-lldbDescription branch July 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants