[SwiftSyntax] Enable Package CMO if possible #75304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-syntax#2736 |
|
swiftlang/swift-syntax#2736 |
rintaro
force-pushed
the
swiftsyntax-package-cmo
branch
from
a18777c to
7a2883e
Compare
rintaro
force-pushed
the
swiftsyntax-package-cmo
branch
from
7a2883e to
ff74dee
Compare
The compiler crashes when compiling swift files importing package-cmo enabled '.swiftmodule'. Avoid that by not-using '.swiftmodule'.
rintaro
force-pushed
the
swiftsyntax-package-cmo
branch
from
ff74dee to
f0808e5
Compare
|
swiftlang/swift-syntax#2736 |
1 similar comment
|
swiftlang/swift-syntax#2736 |
rintaro
changed the title
edymtt
reviewed
Jul 18, 2024
| endfunction() | ||
|
|
||
| # Test if the Swift compiler supports -disable-implicit-<module>-module-import. | ||
| macro(swift_supports_implicit_module module_name out_var) |
There was a problem hiding this comment.
(Optional) There is a function with the same name in cmake/modules/SwiftImplicitImport.cmake -- we may consider folding that into this new implementation.
There was a problem hiding this comment.
This PR does remove cmake/modules/SwiftImplicitImport.cmake and replaces swift_supports_implicit_module function with this new implementation.
bnbarham
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for swiftlang/swift-syntax#2736
The compiler crashes when compiling swift files importing package-cmo enabled
.swiftmodule. Avoid that by not-using.swiftmodule.