Skip to content

[6.0][SwiftSyntax] Enable Package CMO if possible #75355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 18, 2024

Cherry-pick #75304 (and #72405) into release/6.0

  • Explanation: Enable package CMO for swift-syntax libraries. swift-syntax libraries in the compiler are library-evolution enabled for reasons, but that is causing considerable slowness. Enable package CMO if the builder compiler support it.
  • Scope: swift-syntax
  • Risk: Mid. Package CMO is a new technology recently landed
  • Testing: Passes current test suite
  • Issue: Part of rdar://130478685
  • Reviewer: Ben Barham (@bnbarham)

edymtt and others added 2 commits July 18, 2024 14:32
Such module usages are not relevant for the final build, they are used
only to detect the capabilities of the compiler.

This generalizes swiftlang#68453, and would be needed for Apple internal
configurations that set `SWIFT_LOADED_MODULE_TRACE_FILE` when building
the compiler.

Addresses rdar://124954349

(cherry picked from commit 5aaaae5)
The compiler crashes when compiling swift files importing package-cmo
enabled '.swiftmodule'. Avoid that by not-using '.swiftmodule'.

(cherry picked from commit f0808e5)
@rintaro rintaro requested a review from a team as a code owner July 18, 2024 22:30
@rintaro
Copy link
Member Author

rintaro commented Jul 18, 2024

swiftlang/swift-syntax#2740
@swift-ci Please test

@rintaro rintaro merged commit 3e7fa6b into swiftlang:release/6.0 Jul 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants