Skip to content

[MoveOnlyAddressChecker] Exclusivity handles DeadEnds. #75404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jul 22, 2024

Switch to the areUsesWithinBoundary API which takes dead-ends into account.

rdar://131960619
Fixes #75312

@nate-chandler nate-chandler requested a review from kavon as a code owner July 22, 2024 20:51
Switch to the areUsesWithinBoundary API which takes dead-ends into
account.

rdar://131960619
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please apple silicon benchmark

Copy link
Member

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps in a future PR, should we eliminate isWithinBoundary entirely then?

@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jul 22, 2024

It needs to take a nullable dead-end blocks argument (in the fullness of time).

@nate-chandler nate-chandler merged commit cc8af17 into swiftlang:main Jul 23, 2024
8 checks passed
@nate-chandler nate-chandler deleted the rdar131960619 branch July 23, 2024 03:26
@ktoso
Copy link
Contributor

ktoso commented Jul 23, 2024

Resolves #75312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected exclusivity violation from withUnsafeBufferPointer
4 participants