[SourceKit] Run interface generation request on a deep stack #75576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the generated interface for WinSDK can overflow the stack. Treat it as a semantic request to run it on a large stack. Fixes swiftlang/sourcekit-lsp#1115 rdar://123944504
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
hamishknight
approved these changes
Jul 31, 2024
| @@ -938,7 +938,7 @@ handleRequestEditorOpenInterface(const RequestDict &Req, | |||
| std::optional<StringRef> InterestedUSR = Req.getString(KeyInterestedUSR); | |||
| return Rec(editorOpenInterface(*Name, *ModuleName, GroupName, Args, | |||
| SynthesizedExtension, InterestedUSR)); | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| static void handleRequestEditorOpenHeaderInterface( | |||
There was a problem hiding this comment.
While here, should we also do the same for header interfaces?
There was a problem hiding this comment.
Let’s only change this request for now. We don’t use the open header interface on Windows (ie. from SourceKit-LSP) and it hasn’t been an issue on macOS. At some point we should probably re-think what queues all the callbacks etc. run on and whether they need a deep stack…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the generated interface for WinSDK can overflow the stack. Treat it as a semantic request to run it on a large stack.
Fixes swiftlang/sourcekit-lsp#1115
rdar://123944504