Skip to content

[SourceKit] Run interface generation request on a deep stack #75576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[SourceKit] Run interface generation request on a deep stack #75576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/SourceKit/tools/sourcekitd/lib/Service/Requests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ static void
handleRequestEditorOpenInterface(const RequestDict &Req,
SourceKitCancellationToken CancellationToken,
ResponseReceiver Rec) {
{
handleSemanticRequest(Req, Rec, [Req, Rec]() {
SmallVector<const char *, 8> Args;
if (getCompilerArgumentsForRequestOrEmitError(Req, Args, Rec))
return;
Expand All @@ -938,7 +938,7 @@ handleRequestEditorOpenInterface(const RequestDict &Req,
std::optional<StringRef> InterestedUSR = Req.getString(KeyInterestedUSR);
return Rec(editorOpenInterface(*Name, *ModuleName, GroupName, Args,
SynthesizedExtension, InterestedUSR));
}
});
}

static void handleRequestEditorOpenHeaderInterface(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While here, should we also do the same for header interfaces?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s only change this request for now. We don’t use the open header interface on Windows (ie. from SourceKit-LSP) and it hasn’t been an issue on macOS. At some point we should probably re-think what queues all the callbacks etc. run on and whether they need a deep stack…

Expand Down