[CMake] [Darwin] Don't build the SDK overlays by default on Apple platforms #75918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
ad6dbb9 to
e6b4b4d
Compare
|
This isn't enough to allow Swift to build against the current macOS 15.0 beta, but it's the upstream translation of what was done for rdar://115192929 and I think we'll need this all. |
al45tair
reviewed
Aug 16, 2024
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
e6b4b4d to
ecf318f
Compare
ian-twilightcoder
changed the title
|
Alright, trying again, stole a few changes from #75902 that it looks like I missed in the original change |
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
ecf318f to
31cc144
Compare
It was easier to split the |
|
Looks like we're going to need #75914 before we can do this one. |
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
31cc144 to
dabd03b
Compare
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
dabd03b to
caa0a3a
Compare
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
3 times, most recently
from
1163ac5 to
71686b6
Compare
ian-twilightcoder
requested review from
slavapestov,
AnthonyLatsis,
hborla,
QuietMisdreavus,
xymus,
xedin,
jckarter,
ahoppen and
bnbarham
as code owners
ian-twilightcoder
removed request for
rintaro,
jckarter,
xymus,
rjmccall,
DougGregor,
CodaFi,
ahoppen,
QuietMisdreavus,
hborla,
hamishknight,
eeckstein,
tshortli and
AnthonyLatsis
|
This is stacked on top of #75914 and has to wait for that one (or whatever it gets split out to) before this can be rebased retested and merged. |
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
2 times, most recently
from
fbc82aa to
cde5927
Compare
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
4 times, most recently
from
4cb5bdd to
e75a97c
Compare
…tforms The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing. %target-swift-emit-pcm doesn't use the sdk, but %target-swift-frontend does, which will cause them to have a mismatch with "builtin headers belong to system modules, and _Builtin_ modules are ignored for cstdlib headers" aka LANGOPT(BuiltinHeadersInSystemModules) aka -fbuiltin-headers-in-system-modules. rdar://115192929
ian-twilightcoder
force-pushed
the
new-apple-sdk-build-fixes
branch
from
e75a97c to
8959dd9
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing.
rdar://115192929