[CMake] [Darwin] Don't build the SDK overlays by default on Apple platforms #76359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-twilightcoder
requested review from
jckarter,
artemcm,
a team and
eeckstein
as code owners
ian-twilightcoder
force-pushed
the
dont-build-overlays-on-apple
branch
from
e6b149c to
54e37bd
Compare
ian-twilightcoder
force-pushed
the
dont-build-overlays-on-apple
branch
2 times, most recently
from
bb59e00 to
661f033
Compare
ian-twilightcoder
force-pushed
the
dont-build-overlays-on-apple
branch
from
d27a3c2 to
aea0234
Compare
edymtt
approved these changes
Sep 11, 2024
ian-twilightcoder
force-pushed
the
dont-build-overlays-on-apple
branch
2 times, most recently
from
4619b09 to
edade50
Compare
…tforms The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing. rdar://115192929
ian-twilightcoder
force-pushed
the
dont-build-overlays-on-apple
branch
from
b0ddace to
5bf2c93
Compare
|
@swift-ci smoke test |
|
@swift-ci test |
|
This is the replacement for #75918. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apple SDKs have been providing the Darwin overlay since macOS 10.14.4, iOS 12.2, et al. More recently the SDK version has diverged from the Swift version making them incompatible. Stop building the overlay from Swift. Once the SDK overlays aren't being built, the clang overlays need to be built in testing.
rdar://115192929
This reverts commit c6f81cb, reversing changes made to adf3bde.