[SymbolGraphGen] don't emit both requirementOf and optionalRequirementOf for the same relationship #76983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relationship rdar://83519993
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://83519993
This PR changes the relationship emitting logic in SymbolGraphGen so that optional protocol requirements don't generate both a
requirementOfandoptionalRequirementOfrelationship. This confuses tools like Swift-DocC, which render these relationships as both optional and required, even though the former should override it. To prevent this confusion, we can formalize the notion thatoptionalRequirementOfrelationships imply arequirementOfrelationship, and only emit the former when it's necessary.