Skip to content

[SymbolGraphGen] fix nondeterminism in OptionalRequirementOf test #77276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://138773605

The test update in #76983 introduced a nondeterministic failure, due to the way symbol graph data is erratically ordered. This PR changes the test to be more deterministic.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test Linux

1 similar comment
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@QuietMisdreavus
Copy link
Contributor Author

@aschwaighofer The test i modified seems to have passed, even if the overall smoke test run did not.

@QuietMisdreavus QuietMisdreavus merged commit 108ad6f into main Oct 31, 2024
3 checks passed
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/optional-requirement-test branch October 31, 2024 20:18
QuietMisdreavus added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant