[Frontend/AST] Add -interface-compiler-version option to frontend/modules
#77216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterfaces This option is going to be used to indicate what compiler was used to build swift interface/module which is required for SE-0438.
…sed to build a `ModuleDecl`
xedin
requested review from
artemcm,
xymus,
tshortli,
DougGregor,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
xedin
changed the title
-swift-compiler-version option to frontend-swift-compiler-version option to frontend/modules
artemcm
approved these changes
Oct 25, 2024
Swiftinterface files are always built with "current" compiler version, which means that `-swift-compiler-version` has no effect in this context.
xedin
force-pushed
the
add-swift-compiler-version
branch
from
b696f5a to
2d8751b
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
…m swiftinterface If swiftinterface doesn't have `-swift-compiler-version` flag it means that it was generated with an older version of the Swift compiler. In such cases it would be incorrect to use "current" compiler version because the field is intended to indicate the compiler the swiftinterface was built with.
|
@swift-ci please test |
…ace-compiler-version` It might be unexpected to future users that `-swift-compiler-version` would produce a version aligned to .swiftinterface instead of one used to build the .swiftmodule file. To avoid this possible confusion, let's scope down the version to `-interface-compiler-version` flag and `SWIFT_INTERFACE_COMPILER_VERSION` option in the module.
|
@swift-ci please test |
xedin
changed the title
-swift-compiler-version option to frontend/modules-interface-compiler-version option to frontend/modules
xedin
added a commit
to swiftlang/swift-driver
that referenced
this pull request
Oct 30, 2024
This option was introduced by swiftlang/swift#77216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is going to be used to indicate what compiler was used
to build swift interface/module which is required for SE-0438.