[Frontend/ConstraintSystem] NFC: SE-0438 implementation enhancements #77302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c members Replaces feature flag check with module compiler version check which implements the behavior discussed in the SE-0438.
…atic member references Libraries of modules built with older compilers (< 6.1) don't have symbols required to enable staitc member support in key path context.
This is a temporary way to land SE-0438 changes without disrupting anything else.
xedin
requested review from
hborla,
slavapestov,
eeckstein,
jckarter and
DougGregor
as code owners
|
cc @amritpan |
|
@swift-ci please test |
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
-interface-compiler-versionoption introduced by #77216and corresponding way to detect that in .swiftmodule we can switch over to use that instead of a flag and provide
a custom diagnostic that instructs users to rebuild affected modules before feature can be used.