Skip to content

[macCatalyst] Add some build presets for CI testing #77386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drodriguez
Copy link
Contributor

None of the presets exercise macCatalyst at the moment. The presets provided in this commit are not used by default, and will need to be invoked specially with the Swift CI bot, but at least it will allow testing the macCatalyst features.

None of the presets exercise macCatalyst at the moment. The presets
provided in this commit are not used by default, and will need to be
invoked specially with the Swift CI bot, but at least it will allow
testing the macCatalyst features.
@drodriguez
Copy link
Contributor Author

preset=buildbot_incremental,tools=RA,stdlib=RA,test=macCatalyst,type=device
@swift-ci please test with preset macOS platform

@drodriguez
Copy link
Contributor Author

Failed Tests (4):
  Swift(macosx-x86_64) :: ClangImporter/availability_maccatalyst.swift
  Swift(macosx-x86_64) :: ClangImporter/availability_maccatalyst_app_extension.swift
  Swift(macosx-x86_64) :: IRGen/temporary_allocation/codegen_very_large_allocation.swift
  Swift(macosx-x86_64) :: Misc/maccatalyst_load_commands.swift

For ClangImporter/availability_maccatalyst.swift and ClangImporter/availability_maccatalyst_app_extension.swift needs to modify https://github.com/swiftlang/swift/blob/main/lib/ClangImporter/ClangImporter.cpp#L2648-L2651 and outside treatDeprecatedAsUnavailable to avoid implicit availability for macCatalyst overriding the iOS availability attribute. availableOnIOSButUnavailableOnmacCatalyst and others don't exist and unavailableOnIOS is incorrectly named.

@drodriguez
Copy link
Contributor Author

@swift-ci please test

@drodriguez drodriguez marked this pull request as ready for review November 13, 2024 22:38
@drodriguez
Copy link
Contributor Author

@shahmishal : can you check if this follows the right naming? It is not clear to me if Apple has some presets internally for macCatalyst or if these ones will interfere. It is useful in PRs like #77506 to show that the current open source tests are not passing for macCatalyst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant