macCatalyst availability fixes #77506
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the presets exercise macCatalyst at the moment. The presets provided in this commit are not used by default, and will need to be invoked specially with the Swift CI bot, but at least it will allow testing the macCatalyst features.
Trying to fix both availability_maccatalyst and availability_maccatalyst_app_extension. Success in the former, failure in the former. It can be an incorrect recreation of the AvailabilityExtras.h missing pieces, but the logic and the influences of iOS app extensions in macCatalyst app extensions either requires a lot more code, or I have not been able to find the right incantation.
|
preset=buildbot_incremental,tools=RA,stdlib=RA,test=macCatalyst,type=device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work from #77386
Trying to fix both
ClangImporteravailability_maccatalyst.swiftandClangImporter/availability_maccatalyst_app_extension.swift. "Success" in the former, failure in the former.It can be an incorrect recreation of the
AvailabilityExtras.hmissing pieces, but the logic and the influences of iOS app extensions in macCatalyst app extensions either requires a lot more code, or I have not been able to find the right incantation.@tshortli: Can you have a look at this? (and maybe also the other failing tests in #77386?) I think there's some missing pieces in the open source implementation. I tried to guess them the best I can, but I cannot find the right code to make everything work. Thanks!