Skip to content

[IRGen] Check if type is empty instead of void in CallEmission::emitT… #77965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Dec 5, 2024

…oUnmappedExplosionWithDirectTypedError

rdar://140573912

This caused assertions to fail when using other empty types, like Never as the result type on typed throwing functions.

…oUnmappedExplosionWithDirectTypedError

rdar://140573912

This caused assertions to fail when using other empty types, like `Never` as the result type on typed throwing functions.
@drexin drexin requested a review from rjmccall as a code owner December 5, 2024 00:01
@drexin
Copy link
Contributor Author

drexin commented Dec 5, 2024

@swift-ci smoke test

1 similar comment
@drexin
Copy link
Contributor Author

drexin commented Dec 5, 2024

@swift-ci smoke test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drexin drexin merged commit dd97862 into swiftlang:main Dec 5, 2024
3 checks passed
@drexin drexin deleted the wip-140573912 branch December 5, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants