Skip to content

[6.1][IRGen] Check if type is empty instead of void in CallEmission::emitToUnmappedExplosionWithDirectTypedError #77975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

[6.1][IRGen] Check if type is empty instead of void in CallEmission::emitToUnmappedExplosionWithDirectTypedError #77975

merged 1 commit into from
Dec 5, 2024

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Dec 5, 2024

  • Explanation: The check was too narrow, only checking for Void, which caused assertions to fail when using other empty types, like Never as the result type on typed throwing functions.
  • Scope: Typed throws, when compiling with asserting compiler.
  • Issues: rdar://140573912
  • Original PRs: [IRGen] Check if type is empty instead of void in CallEmission::emitT… #77965
  • Risk: Low. Crash only occurred on asserting compilers and the change does not change the generated code.
  • Testing: Added a regression test. Existing tests still pass.
  • Reviewers: @rjmccall

@drexin
[IRGen] Check if type is empty instead of void in CallEmission::emitT…
b66d4f6 
…oUnmappedExplosionWithDirectTypedError

rdar://140573912

This caused assertions to fail when using other empty types, like `Never` as the result type on typed throwing functions.
@drexin drexin added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.1 labels Dec 5, 2024
@drexin drexin requested a review from a team as a code owner December 5, 2024 09:21
@drexin
Copy link
Contributor Author

drexin commented Dec 5, 2024

@swift-ci test

@drexin drexin merged commit de1ef75 into swiftlang:release/6.1 Dec 5, 2024
5 checks passed
@drexin drexin deleted the wip-140573912-6.1 branch December 5, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drexin @DougGregor