Sema: Diagnose @backDeployed functions with missing bodies in swiftinterfaces
#78327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
xymus,
hborla,
slavapestov and
xedin
as code owners
tshortli
changed the title
@backDeployed functions with missing bodies in swiftinterfaces
nkcsgexi
approved these changes
Dec 20, 2024
…terfaces. A `@backDeployed` function printed in a `.swiftinterface` must have a function body so that SILGen can emit a fallback copy to call when the back deployed function is unavailable. Previously, the compiler would crash in SILGen when compiling an interface containing a back deployed function without a body. Resolves rdar://141593108.
tshortli
force-pushed
the
back-deployed-without-body
branch
from
3951856 to
ebda3e2
Compare
|
@swift-ci please test |
artemcm
approved these changes
Dec 20, 2024
|
I hit an issue with this diagnostic in a toolchain build in #78332, but it feels more like a dependency-related build issue than a problem with this PR. |
Ah yeah, I think this PR was premature. We need to fix the issue that inspired this change first. PR testing gave me a false sense of security, sorry about that! |
|
Yeah, the toolchain build succeeds with this reverted and fails with it in place, so I put up a revert PR (#78345). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
@backDeployedfunction printed in a.swiftinterfacemust have a function body so that SILGen can emit a fallback copy to call when the back deployed function is unavailable. Previously, the compiler would crash in SILGen when compiling an interface containing a back deployed function without a body.Resolves rdar://141593108.