Strict safety improvements toolchain workaround #78340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te associated with its type
Under strict concurrency and memory safety, uses of `@unchecked Sendable` conformances are considered unsafe. Diagnose the use sites, not the declaration site.
@preconcurrency imports disable Sendable checking, which can lead to data races that undermine memory safety. Diagnose such imports, and require `@safe(unchecked)` to suppress the diagnostic.
Aligns with the current proposal and fixes rdar://127128995
…o deal with the warnings
…orporate @unsafe Protocol conformances have a handful attributes that can apply to them directly, including @unchecked (for Sendable), @preconcurrency, and @retroactive. Generalize this into an option set that we carry around, so it's a bit easier to add them, as well as reworking the serialization logic to deal with an arbitrary number of such options. Use this generality to add support for @unsafe conformances, which are needed when unsafe witnesses are used to conform to safe requirements. Implement general support for @unsafe conformances, including producing a single diagnostic per missing @unsafe that provides a Fix-It and collects together all of the unsafe witnesses as notes.
…n't need to be @unsafe What we should actually do with SerialExecutor conformances is not yet clear, though.
The `@unchecked` conformance is effectively the same as `@safe(unchecked)`, in that it asserts memory safety in a place where it cannot be automatically checked. But once that has been asserted, there is no reason to diagnose anywhere else. While here, drop the "unsafe declaration here" note, which isn't adding value but did add noise. Thanks, Alex!
… swiftinterfaces." This reverts commit ebda3e2.
DougGregor
requested review from
xymus,
ktoso,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
tshortli,
ahoppen,
bnbarham,
hamishknight,
rintaro,
artemcm,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun and
CodaFi
as code owners
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #78332, but with #78327 temporarily reverted because it looks like it caused this build failure: