[ScanDependency] Swift source module should not have build args for modules #78331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…odules When planning for a swift source module, it should not get build commands for its module dependencies. Those dependencies should be planned and added by swift-driver. This is another regression from swiftlang#76700 that causes unnecessary increase of build command-line size. rdar://141843125
cachemeifyoucan
force-pushed
the
eng/PR-141843125
branch
from
017f01e to
1e399d5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When planning for a swift source module, it should not get build commands for its module dependencies. Those dependencies should be planned and added by swift-driver.
This is another regression from #76700 that causes unnecessary increase of build command-line size.
rdar://141843125