Fix SILCombine of existential applies #78412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
meg-gupta
force-pushed
the
fixsilcombine
branch
from
df72b54 to
fa445a6
Compare
|
I don't think this is a good idea. Inserting a copy+destroy might be worse than not propagating the concrete type of existential. The optimizer should never insert copies which are not there in the first place. I suggest to just not do the optimization in such a case. |
meg-gupta
force-pushed
the
fixsilcombine
branch
2 times, most recently
from
183582e to
e4c263c
Compare
eeckstein
reviewed
Jan 3, 2025
This code was previously creating illegal unchecked_ref_cast with same source and destination.
meg-gupta
force-pushed
the
fixsilcombine
branch
3 times, most recently
from
d1f964e to
13027ae
Compare
|
@swift-ci test |
eeckstein
reviewed
Jan 7, 2025
|
This PR fixes some source compatibility failures: rdar://142298318 |
Don't use previously found owned concrete values in ossa. They will consumed by forwarding operations like init_existential_ref. Instead create an unconditional cast of the opened existential to concrete type and use that to create a concrete apply.
meg-gupta
force-pushed
the
fixsilcombine
branch
from
13027ae to
ed0483b
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci smoke test Linux platform |
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78354 enabled silcombine to propagate concrete type of existentials in ossa. However when the concrete value is
ownedit is consumed by theinit_existential_refforwarding operation. In this case we create an unchecked cast of the opened existential to the concrete type and use that in the apply.