[build-script-impl] Add support for building benchmarks on linux but disable it in all currently defined presets for linux. #7860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
…disable it in all currently defined presets for linux.
…unning the benchmarks. No comparison is made. This is just for validation that things are working.
gottesmm
force-pushed
the
build_script_impl_linux_benchmarks
branch
from
a552cbf to
5dbc58c
Compare
|
I am going to spend a little bit of time getting this in. |
…6_64. I put in a small little kludge to add support for this. The better solution is to refactor the supports_benchmark property from Platform to Target. We already have a similar abstraction problem with armv7 target on Darwin, where we explicitly turn off benchmarking. *NOTE* Building the benchmarks for linux still requires more cmake work. I am making some changes in a subsequent commit series to do this. If you try to compile the benchmarks, you will hit an error where ninja says that it doesn't know about the swift-benchmark-linux-x86_64 target.
|
NOTE This is just the build-script work. I need to add some more stuff to get the cmake side to work. |
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
|
@airspeedswift In this PR I also added a mac os x preset that builds (and maybe, I am not sure) runs the benchmarks. Perfect for adding new benchmarks. |
|
@airspeedswift You should be able to use the special preset triggering message to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all.