Skip to content

[benchmark] Compile and run benchmarks on Linux #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

mtake
Copy link
Contributor

@mtake mtake commented Mar 6, 2017

Exclude Objective-C or Mach specific implementations, or replace them with POSIX based implementations so that we can compile and run benchmarks on Linux.

(This PR supersedes #7810 in favor of not including unrelated merged commits from other people.)

@mtake
Copy link
Contributor Author

mtake commented Mar 6, 2017

@gottesmm I noticed #7860 has been merged. I would appreciate if you can do the remaining integration work for building the benchmarks on Linux in the smoketest/full test presets.

@gottesmm
Copy link
Contributor

gottesmm commented Mar 6, 2017

@mtake It is going to take me time to do it. I have other things on my schedule that are more important. Sorry.

Additionally, that change was actually reverted since some people don't include their buildbot config in presets * looks at lldb * = p. So I didn't see it to update it.

@lplarson
Copy link
Contributor

lplarson commented Mar 6, 2017

@swift-ci smoke test

@gottesmm
Copy link
Contributor

gottesmm commented Mar 6, 2017

@lplarson IMO, we should just get this in as an incremental improvement as long as it does not break the linux build or affect the darwin build. I wish that we did have the infrastructure in place so we could get this on in the normal linux build. But my schedule is not being helpful. I don't want to hold this up.

@lplarson
Copy link
Contributor

lplarson commented Mar 6, 2017

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Mar 6, 2017

Build comment file:

Build failed before running benchmark.


@lplarson
Copy link
Contributor

lplarson commented Mar 6, 2017

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Mar 7, 2017

Build comment file:

Build failed before running benchmark.


@lplarson
Copy link
Contributor

lplarson commented Mar 7, 2017

@swift-ci benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Mar 7, 2017

Build comment file:

Build failed before running benchmark.


@mtake
Copy link
Contributor Author

mtake commented Mar 8, 2017

@lplarson
Copy link
Contributor

lplarson commented Mar 8, 2017

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 66fc403 into swiftlang:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants