Skip to content

Expose immortal String initialization for Foundation #78661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Jan 15, 2025

Fixes rdar://142987784

@Catfish-Man Catfish-Man requested a review from milseman January 15, 2025 20:08
@Catfish-Man Catfish-Man self-assigned this Jan 15, 2025
@Catfish-Man Catfish-Man requested a review from a team as a code owner January 15, 2025 20:08
@Catfish-Man Catfish-Man force-pushed the the-carriage-held-but-just-ourselves-and-immortality branch 2 times, most recently from a086dc1 to 518113a Compare January 15, 2025 20:46
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@Catfish-Man Catfish-Man enabled auto-merge (squash) January 15, 2025 21:12
@Catfish-Man Catfish-Man force-pushed the the-carriage-held-but-just-ourselves-and-immortality branch from 518113a to b8d694b Compare January 15, 2025 23:22
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@Catfish-Man Catfish-Man force-pushed the the-carriage-held-but-just-ourselves-and-immortality branch from 8d2b6a1 to c3a753d Compare January 16, 2025 22:30
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test Linux platform

@Catfish-Man
Copy link
Contributor Author

Linux failure is unrelated to this change, introduced by swiftlang/swift-docc#1143

@porglezomp
Copy link
Contributor

@swift-ci please smoke test linux platform

@porglezomp
Copy link
Contributor

@swift-ci please test linux platform

@Catfish-Man Catfish-Man merged commit 600dcd0 into main Jan 19, 2025
3 of 4 checks passed
@Catfish-Man Catfish-Man deleted the the-carriage-held-but-just-ourselves-and-immortality branch January 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants