-
Notifications
You must be signed in to change notification settings - Fork 146
Resolve all current code warnings #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
d-ronnqvist
merged 5 commits into
swiftlang:main
from
d-ronnqvist:fix-warnings-jan-2025
Jan 16, 2025
Merged
Resolve all current code warnings #1143
d-ronnqvist
merged 5 commits into
swiftlang:main
from
d-ronnqvist:fix-warnings-jan-2025
Jan 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
Note: this requires SwiftNIO 2.78.0 or later Also, remove unused non-sendable HTTP handlers in tests
755fdb1
to
296fe6a
Compare
@swift-ci please test |
QuietMisdreavus
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
tshortli
added a commit
to tshortli/swift-docc
that referenced
this pull request
Jan 17, 2025
This reverts commit b1d4c6c.
tshortli
added a commit
that referenced
this pull request
Jan 18, 2025
d-ronnqvist
added a commit
that referenced
this pull request
Jan 20, 2025
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Jan 23, 2025
3 tasks
d-ronnqvist
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This resolves or works around all current warnings.
Dependencies
None.
Testing
bin/test
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/test
script and it succeeded[ ] Updated documentation if necessary