Skip to content

Resolve all current code warnings #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

d-ronnqvist
Copy link
Contributor

Bug/issue #, if applicable:

Summary

This resolves or works around all current warnings.

Dependencies

None.

Testing

  • Run bin/test
  • There shouldn't be any warnings from building the source or the tests.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist force-pushed the fix-warnings-jan-2025 branch from 755fdb1 to 296fe6a Compare January 16, 2025 12:40
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@d-ronnqvist d-ronnqvist merged commit b1d4c6c into swiftlang:main Jan 16, 2025
2 checks passed
@d-ronnqvist d-ronnqvist deleted the fix-warnings-jan-2025 branch January 16, 2025 16:24
tshortli added a commit to tshortli/swift-docc that referenced this pull request Jan 17, 2025
tshortli added a commit that referenced this pull request Jan 18, 2025
d-ronnqvist added a commit that referenced this pull request Jan 20, 2025
d-ronnqvist added a commit that referenced this pull request Feb 11, 2025
* Revert "Revert "Resolve all current code warnings (#1143)" (#1145)"

2bd30b1

* Don't update to a new version of Swift NIO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants