Skip to content

Revert "Resolve all current code warnings (#1143)" #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 17, 2025

The changes from #1143 are blocking PRs from being merged in the Swift compiler repo because the NIO dependency is not new enough (example). Updating the version of NIO that this project depends on will need to be done in conjunction with an update to update-checkout.sh in the https://github.com/swiftlang/swift repo.

@tshortli
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this blanket revert so the compiler is unblocked. A targeted un-revert can be made to add the non-NIO warning fixes, or we can go ahead and update the compiler's dependencies first.

@tshortli tshortli merged commit 2bd30b1 into swiftlang:main Jan 18, 2025
2 checks passed
@tshortli tshortli deleted the revert-1143 branch January 18, 2025 00:34
d-ronnqvist added a commit that referenced this pull request Jan 20, 2025
d-ronnqvist added a commit that referenced this pull request Feb 11, 2025
* Revert "Revert "Resolve all current code warnings (#1143)" (#1145)"

2bd30b1

* Don't update to a new version of Swift NIO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants