AST: Fix SequenceExpr handling in AvailabilityScopeBuilder #78706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
force-pushed
the
sequence-expr-availability-scopes
branch
from
c269d4b to
b050665
Compare
Since availability scopes may be built at arbitrary times, the builder may encounter ASTs where SequenceExprs still exist and have not been folded, or it may encounter folded SequenceExprs that have not been removed from the AST. To avoid a double visit, track whether a SequenceExpr is folded and then customize how ASTVisitor handles folded sequences. Resolves rdar://142824799 and swiftlang#78567.
tshortli
force-pushed
the
sequence-expr-availability-scopes
branch
from
b050665 to
87308e3
Compare
|
@swift-ci please smoke test |
xedin
approved these changes
Jan 17, 2025
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since availability scopes may be built at arbitrary times, the builder may encounter ASTs where
SequenceExprs still exist and have not been folded, or it may encounter foldedSequenceExprs that have not been removed from the AST.To avoid a double visit, track whether a
SequenceExpris folded and then customize howASTVisitorhandles folded sequences.Resolves rdar://142824799 and #78567.