Skip to content

Implement experimental@execution(concurrent | caller) attribute #78704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 17, 2025

Implements experimental @execution(concurrent | caller) declaration attribute and it's validation.

This attribute is:

  • tied to NonIsolatedAsyncInheritsIsolationFromContext experimental feature
  • allowed on async functional declarations
  • concurrent behavior cannot be used with nonisolated, global actor, isolated and @isolated(any) marked functions/parameters.

Resolves: rdar://142920095

@xedin
Copy link
Contributor Author

xedin commented Jan 17, 2025

@swift-ci please clean test

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Jan 17, 2025

@swift-ci please clean test

@xedin xedin changed the title [Parse/AST/Sema] Implement experimental@execution(concurrent | caller) attribute Implement experimental@execution(concurrent | caller) attribute Jan 17, 2025
@xedin
Copy link
Contributor Author

xedin commented Jan 17, 2025

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Jan 17, 2025

@swift-ci please test macOS platform

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but looks reasonable

@xedin
Copy link
Contributor Author

xedin commented Jan 17, 2025

swiftlang/swift-docc#1145
@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 18, 2025

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 20, 2025

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Jan 20, 2025

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Jan 20, 2025

@swift-ci please test Windows platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Jan 20, 2025

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Jan 20, 2025

@swift-ci please smoke test Windows platform

@xedin xedin merged commit 82e111a into swiftlang:main Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants