Make Optional<T>.TangentVector methods inlineable #78796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Tagging @JaapWijnen |
|
Great! I'll add one for the Floating point methods too. Noticed they were missing there in a few cases as well. |
|
@swift-ci please smoke test Linux |
rxwei
approved these changes
Jan 31, 2025
|
@swiftlang/standard-librarians Will you please check it out? Thanks! |
lorentey
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables lots of possible optimizations when optionals are used in autodiff code.
As there is no stable ABI for
Differentiable, there is no ABI break.