Skip to content

Mark Differentiation related FloatingPoint methods with @inlinable #78806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

JaapWijnen
Copy link
Contributor

Mark Differentiation related FloatingPoint methods with @inlinable for more optimization opportunities
Inspired by earlier performance improvements in #75778 and #78796

As there is no stable ABI for Differentiable, there is no ABI break.

@JaapWijnen JaapWijnen requested a review from a team as a code owner January 22, 2025 12:15
@JaapWijnen
Copy link
Contributor Author

tagging @asl

@asl asl added the AutoDiff label Jan 22, 2025
@asl
Copy link
Contributor

asl commented Jan 23, 2025

@swift-ci please test

@JaapWijnen
Copy link
Contributor Author

@rxwei @lorentey Could I ask you for a review?

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all make sense, thanks Jaap! 👍

@asl asl merged commit bd4730f into swiftlang:main Feb 20, 2025
5 checks passed
@JaapWijnen
Copy link
Contributor Author

JaapWijnen commented Feb 21, 2025

Thanks for the review and merge Karoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants