Skip to content

[6.1] AST: Only apply MemberImportVisibility to lookups from the main module #78877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

[6.1] AST: Only apply MemberImportVisibility to lookups from the main module #78877

merged 1 commit into from
Jan 24, 2025

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jan 24, 2025 •
edited
Loading

@tshortli tshortli requested a review from a team as a code owner January 24, 2025 03:52
@tshortli tshortli added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.1 labels Jan 24, 2025
@tshortli tshortli force-pushed the cfobject-hashable-member-import-visibility-6.1 branch from cfbfb58 to 1533f54 Compare January 24, 2025 03:54
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli
AST: Only apply MemberImportVisibility to lookups from the main module.
4fe2a21 
MemberImportVisibility rules should only apply to source code in the main
module. The rules were being applied when resolving witnesses for synthesized
Hashable conformances on CF types imported by ClangImporter, which caused the
lookups to fail and bad conformances to be generated.

Resolves swiftlang#78870 and rdar://142433039.
@tshortli tshortli force-pushed the cfobject-hashable-member-import-visibility-6.1 branch from 1533f54 to 4fe2a21 Compare January 24, 2025 05:11
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli enabled auto-merge January 24, 2025 05:12
@tshortli
Copy link
Contributor Author

@swift-ci please test Linux

@tshortli tshortli linked an issue Jan 24, 2025 that may be closed by this pull request
[Source compatibility suite] vapor_jwt failing to build on macOS with release/6.1 -SIL verification failed: method does not appear in the class's vtable: VerifyClassMethodVisitor(member).Seen || operandType.isForeignReferenceType() #78870
Closed
@tshortli tshortli merged commit c424525 into swiftlang:release/6.1 Jan 24, 2025
5 checks passed
@tshortli tshortli deleted the cfobject-hashable-member-import-visibility-6.1 branch January 24, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.1
Projects
None yet
Milestone
No milestone
2 participants
@tshortli @nkcsgexi