Enable serialization in OSSA #78939
Merged
Enable serialization in OSSA #78939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
ossamoduleson
branch
from
c6ad795 to
e8e8b48
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test source compatibility |
meg-gupta
force-pushed
the
ossamoduleson
branch
from
e8e8b48 to
6f7d356
Compare
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci build toolchain |
|
@swift-ci test source compatibility |
meg-gupta
force-pushed
the
ossamoduleson
branch
from
6f7d356 to
ae82430
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
meg-gupta
force-pushed
the
ossamoduleson
branch
2 times, most recently
from
ac32683 to
3263a29
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci test source compatibility |
|
@swift-ci apple silicon benchmark |
meg-gupta
force-pushed
the
ossamoduleson
branch
from
3263a29 to
2544bcf
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test source compatibility |
|
@swift-ci test macOS |
meg-gupta
force-pushed
the
ossamoduleson
branch
from
2544bcf to
7bfecb1
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci build toolchain |
meg-gupta
requested review from
jckarter,
xymus,
eeckstein,
a team,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
tshortli
reviewed
Jan 30, 2025
| @@ -166,6 +162,7 @@ | |||
| // RUN: cd %t/MCP.O && ls *.swiftmodule > %t/MCP.O/firstFile | |||
| // RUN: cd %t/MCP.O/old && ls *.swiftmodule > %t/MCP.O/secondFile | |||
| // RUN: not diff -u %t/MCP.O/firstFile %t/MCP.O/secondFile | |||
| // XFAIL: * | |||
There was a problem hiding this comment.
Should these tests be deleted?
meg-gupta
force-pushed
the
ossamoduleson
branch
from
d7eac10 to
8be15da
Compare
|
@swift-ci smoke test |
|
Smoke testing now since full tests had passed before a test update |
Disable package cmo test with deserialization warning until rdar://143923551 is fixed. Delete package cmo test with -experimental-skip-deserialization-checks-for-package-cmo SIL verification is stricter and in some cases enabled in release build of the compiler as well with -enable-ossa-modules. This test with -experimental-skip-deserialization-checks-for-package-cmo previously passed even though there were SIL instructions like strong_retain/strong_release on a trivial type. Disable this instance since SIL verification triggers copy_value etc on a trivial type.
If this function is inlined, the optimizer can shrink the lifetime of the `args` parameter. This would deallocate the passed arguments (e.g. `NSString`s) before the are used in the closure.
meg-gupta
force-pushed
the
ossamoduleson
branch
from
8be15da to
20db2a4
Compare
|
@swift-ci smoke test |
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves OSSA to non-OSSA lowering all way after serialization, running the high level pass pipeline on OSSA and enabling serializing SIL in OSSA.