[Distributed] ban typed throws in distributed funcs #78978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
They don't yield a correct error type as we didn't implement it, so rather allow it and risk crashes, ban it until we get the time to implement it. The real solution is to adjust typed throws error inference to do an union of the thrown error of the func and the type thrown by the distributed actor system remote call -- which today always would be (E | Error) -> Error... We could add a new associated type to DAS and then we could make it more proper... resolves rdar://136467528
ktoso
force-pushed
the
wip-fix-error-type-distributed-throws
branch
from
7061bc7 to
a2b3c48
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
hborla
approved these changes
Jan 29, 2025
Co-authored-by: Holly Borla <[email protected]>
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jan 29, 2025
ktoso
commented
Jan 29, 2025
test/Distributed/distributed_actor_unsupported_typed_throws.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't yield a correct error type as we didn't implement it, so rather allow it and risk crashes, ban it until we get the time to implement it.
The real solution is to adjust typed throws error inference to do an union of the thrown error of the func and the type thrown by the distributed actor system remote call -- which today always would be (E | Error) -> Error...
We could add a new associated type to DAS and then we could make it more proper...
resolves rdar://136467528