[Distributed] ban typed throws in distributed funcs #79043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't yield a correct error type as we didn't implement it, so rather allow it and risk crashes, ban it until we get the time to implement it. The real solution is to adjust typed throws error inference to do an union of the thrown error of the func and the type thrown by the distributed actor system remote call -- which today always would be (E | Error) -> Error... We could add a new associated type to DAS and then we could make it more proper... resolves rdar://136467528 Update DiagnosticsSema.def Co-authored-by: Holly Borla <[email protected]> Update test/Distributed/distributed_actor_unsupported_typed_throws.swift
|
@swift-ci please test |
DougGregor
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: typed throws were never correctly implemented for distributed functions and can lead to incorrect code which claims to throw E, but CAN throw
any Error. We should ban typed throws on distributed funcs until we properly solve this integration between those two.Scope/Impact: Low, only distributed funcs which declare typed throws -- which always was incorrect.
Risk: Low, no known to me code does this.
Testing: CI testing
Reviewed by: @hborla
Original PR: #78978
Radar: rdar://136467528