AST: Begin refactoring AvailabilitySpec to support custom domains #79312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include it where it's actually used instead to improve compile times.
Instead of canonicalizing platform versions during parsing and storing two versions, just canonicalize the parsed version on-demand when its requested.
Push all of the members up into the AvailabilitySpec superclass in preparation for removing the subclasses. NFC.
Remove methods that are specific to AvailabilitySpec subclasses and replace them with methods on the superclass if necessary. NFC.
tshortli
requested review from
slavapestov,
hborla,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
tshortli
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hollow out each of the
AvailabilitySpecsubclasses in preparation for adding custom availability domain support toif #available(...)queries.AvailabilitySpecshould eventually become nothing but a bag of parsed details that must be queried via a request to resolve its availability domain, instead of eagerly resolving the domain during parsing. The next step will be to remove the subclasses entirely.